Try to read git hash from environment for dev build #8483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwren
approved these changes
Aug 20, 2025
|
Good news - I was able to figure out how to test this internally without pushing to main. Bad news - it does not work. WIP for now |
|
Working now! |
helin24
added
the
autosubmit
|
Hmm this didn't autosubmit. Maybe because all checks had already gone green once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may address #8476 but I have to push to main to try it out. The kokoro job prints out this variable
KOKORO_GITHUB_COMMIT, but I'm not sure that is available in env for our script.